CLN/TST: Remove agg test from groupby #43557

rhshadrach · 2021-09-13T23:25:34Z

Ensure all linting tests pass, see here for how to run them

Removed test is duplicated of

pandas/pandas/tests/apply/test_frame_apply.py

Lines 1398 to 1406 in e9d0a58

    
           def test_apply_no_suffix_index(): 
        
               # GH36189 
        
               pdf = DataFrame([[4, 9]] * 3, columns=["A", "B"]) 
        
               result = pdf.apply(["sum", lambda x: x.sum(), lambda x: x.sum()]) 
        
               expected = DataFrame( 
        
                   {"A": [12, 12, 12], "B": [27, 27, 27]}, index=["sum", "<lambda>", "<lambda>"] 
        
               ) 
        
               tm.assert_frame_equal(result, expected)

and

pandas/pandas/tests/apply/test_series_apply.py

Lines 410 to 416 in e9d0a58

    
           def test_series_apply_no_suffix_index(): 
        
               # GH36189 
        
               s = Series([4] * 3) 
        
               result = s.apply(["sum", lambda x: x.sum(), lambda x: x.sum()]) 
        
               expected = Series([12, 12, 12], index=["sum", "<lambda>", "<lambda>"]) 
        
               tm.assert_series_equal(result, expected)

mzeitlin11

LGTM, thanks @rhshadrach!

Remove agg test from groupby

0da40f2

rhshadrach added Testing pandas testing functions or related to the test suite Clean labels Sep 13, 2021

rhshadrach changed the title ~~Remove agg test from groupby~~ CLN/TST: Remove agg test from groupby Sep 13, 2021

mzeitlin11 approved these changes Sep 14, 2021

View reviewed changes

mzeitlin11 added this to the 1.4 milestone Sep 14, 2021

mzeitlin11 merged commit e97e103 into pandas-dev:master Sep 14, 2021

rhshadrach deleted the remove_apply_test branch September 14, 2021 03:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CLN/TST: Remove agg test from groupby #43557

CLN/TST: Remove agg test from groupby #43557

rhshadrach commented Sep 13, 2021

mzeitlin11 left a comment

	def test_apply_no_suffix_index():
	# GH36189
	pdf = DataFrame([[4, 9]] * 3, columns=["A", "B"])
	result = pdf.apply(["sum", lambda x: x.sum(), lambda x: x.sum()])
	expected = DataFrame(
	{"A": [12, 12, 12], "B": [27, 27, 27]}, index=["sum", "<lambda>", "<lambda>"]
	)

	tm.assert_frame_equal(result, expected)

	def test_series_apply_no_suffix_index():
	# GH36189
	s = Series([4] * 3)
	result = s.apply(["sum", lambda x: x.sum(), lambda x: x.sum()])
	expected = Series([12, 12, 12], index=["sum", "<lambda>", "<lambda>"])

	tm.assert_series_equal(result, expected)

CLN/TST: Remove agg test from groupby #43557

CLN/TST: Remove agg test from groupby #43557

Conversation

rhshadrach commented Sep 13, 2021

mzeitlin11 left a comment

Choose a reason for hiding this comment